Fix fake pagination for sled_list_uninitialized #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
reviewed
Dec 19, 2023
Comment on lines
4662
to
4665
| _query_params: Query<PaginatedById>, | ||
| ) -> Result<HttpResponseOk<ResultsPage<UninitializedSled>>, HttpError> { | ||
| let apictx = rqctx.context(); | ||
| let handler = async { |
There was a problem hiding this comment.
- I don't think we want to offer a
sort_byquery parameter that we ignore - I'm fine ignoring the
limitparameter, but perhaps we could use it below - I think we want to produce an error if a caller specifies a page token
Suggested change
| _query_params: Query<PaginatedById>, | |
| ) -> Result<HttpResponseOk<ResultsPage<UninitializedSled>>, HttpError> { | |
| let apictx = rqctx.context(); | |
| let handler = async { | |
| query: Query<PaginationParams<EmptyScanParams, ()>>, | |
| ) -> Result<HttpResponseOk<ResultsPage<UninitializedSled>>, HttpError> { | |
| let pag_params = query.into_inner(); | |
| if let dropshot::WhichPage::Next(last_seen) = &pag_params.page { | |
| return Err(Error::invalid_value(last_seen.clone(), "bad page token").into()); | |
| }; | |
| let apictx = rqctx.context(); | |
| let handler = async { |
There was a problem hiding this comment.
Thanks for the tip! Fixed in 06a3851.
openapi/nexus.json
Outdated
Comment on lines
4045
to
4051
| }, | ||
| { | ||
| "in": "query", | ||
| "name": "sort_by", | ||
| "schema": { | ||
| "$ref": "#/components/schemas/IdSortMode" | ||
| } |
There was a problem hiding this comment.
I think ideally this should not be here
There was a problem hiding this comment.
Fixed in 06a3851.
Comment on lines
+4072
to
+4073
| "x-dropshot-pagination": { | ||
| "required": [] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.